fix: Make User_Proxy IGetDisplayNameBackend complient #57452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SystemKeeper
requested review from
ArtificialOwl,
blizzz,
come-nc,
nfebe,
salmart-dev and
sorbaugh
and removed request for
a team
Signed-off-by: Marcel Müller <[email protected]>
SystemKeeper
force-pushed
the
fix/noid/ldap-get-displayname-backend
branch
from
2a009d9 to
f870041
Compare
blizzz
approved these changes
Jan 9, 2026
Contributor
Author
|
/backport to stable32 |
Contributor
Author
|
/backport to stable31 |
CarlSchwan
approved these changes
Jan 12, 2026
This was referenced Jan 12, 2026
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I noticed that the system address book did not update the displayname after it was changed in LDAP. I tried
occ dav:sync-system-addressfirst, but no changes. Then I triedocc user:sync-account-data, but all accounts reported nothing to update. While digging through the code I noticed thatUser_Proxydid not implementIGetDisplayNameBackend(in contrast,Group_Proxydoes for groups). Afterwards, the system address book was correctly updated.(
occ user:sync-account-datadid still report nothing to update, as the displayname is already handled before the sync, because of #39770).I did not find an issue about that, which makes me wonder if there's something I missed here and it should've worked without the interface ...?
Checklist
3. to review, feature component)stable32)